agresch commented on a change in pull request #3306:
URL: https://github.com/apache/storm/pull/3306#discussion_r488874655
##########
File path:
storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java
##########
@@ -40,6 +40,11 @@
"fileUpload",
"getNimbusConf",
"getClusterInfo",
+ "getLeader",
Review comment:
getLeader was added due to a bug below I guess?
##########
File path: storm-core/src/jvm/org/apache/storm/command/GetErrors.java
##########
@@ -42,21 +43,17 @@ public static void main(String[] args) throws Exception {
public void run(Nimbus.Iface client) throws Exception {
GetInfoOptions opts = new GetInfoOptions();
opts.set_num_err_choice(NumErrorsChoice.ONE);
- String topologyId = Utils.getTopologyId(name, client);
-
- TopologyInfo topologyInfo = null;
- if (topologyId != null) {
- topologyInfo = client.getTopologyInfoWithOpts(topologyId,
opts);
- }
-
- Map<String, Object> outputMap = new HashMap<>();
- if (topologyId == null || topologyInfo == null) {
- outputMap.put("Failure", "No topologies running with name
" + name);
- } else {
+ TopologyInfo topologyInfo;
+ Map<String, Object> outputMap = null;
Review comment:
combine these two lines
##########
File path: storm-client/src/py/storm/Nimbus-remote
##########
@@ -75,9 +75,14 @@ if len(sys.argv) <= 1 or sys.argv[1] == '--help':
print(' string downloadChunk(string id)')
print(' string getNimbusConf()')
print(' ClusterSummary getClusterInfo()')
+ print(' getTopologySummaries()')
Review comment:
should these have return types?
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -4747,7 +4866,7 @@ public boolean isTopologyNameAllowed(String name) throws
AuthorizationException,
for (StormBase base : ownerToBasesEntry.getValue()) {
try {
String topoId = state.getTopoId(base.get_name())
- .orElseThrow(() -> new
WrappedNotAliveException(base.get_name() + " is not alive"));
Review comment:
why change this exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
