[GitHub] [storm] Ethanlm commented on a change in pull request #3363: STORM-3724 use blobstore modtime to prevent querying each remote file on update

[GitBox]

Ethanlm commented on a change in pull request #3363:
URL: https://github.com/apache/storm/pull/3363#discussion_r555271721



##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3815,6 +3828,7 @@ public void setBlobMeta(String key, SettableBlobMeta meta)
         throws AuthorizationException, KeyNotFoundException, TException {
         try {
             blobStore.setBlobMeta(key, meta, getSubject());
+            blobStore.updateLastModTime();

Review comment:
       What will happen if `blobStore.setBlobMeta` succeeds then 
`blobStore.updateLastModTime()` fails? Or nimbus crashed before 
`blobStore.updateLastModTime()` can run?
    
   Looks like supervisors will not be notified for this blob update. We should 
update the timestamp before doing the actual operation.
   
   Also, do we need similar code in `updateBlobReplication(String key, int 
replication)`?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org