[GitHub] [storm] agresch commented on a change in pull request #3363: STORM-3724 use blobstore modtime to prevent querying each remote file on update

[GitBox]

agresch commented on a change in pull request #3363:
URL: https://github.com/apache/storm/pull/3363#discussion_r555287880



##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3815,6 +3828,7 @@ public void setBlobMeta(String key, SettableBlobMeta meta)
         throws AuthorizationException, KeyNotFoundException, TException {
         try {
             blobStore.setBlobMeta(key, meta, getSubject());
+            blobStore.updateLastModTime();

Review comment:
       yes, validateModTime() should update the mod time if a file in the 
bucket dir is updated.  There will also be occasional false positive updates if 
a blob is deleted in a bucket dir that contains a different blob file. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org