skysiders commented on PR #3478: URL: https://github.com/apache/storm/pull/3478#issuecomment-1120349522
> Is there a check to see if the directory already exists with more generous permission than requested? Hi @bipinprasad ,thanks for your review. I added a permission check to compare the file's current permissions with the granted permissions. These operations are performed after mkdirs. It can be seen that the mkdirs before the patch are all mkdirs(path, permission), and in the DistributedFileSystem, mkdirs(path, permission) has two functions. If the path does not exist, create the path and its parent directory, and respond to the The directory applies a permission, this permission is not `permission`(the second parameter), but `(permission & umask)`. If path exists, permissions `(permission & umask)` will be applied to the folder. So the patch here just conforms to the program's mdirs for permission checking. So if the file exists and there are generous permission, mkdirs here will re-give the desired permissions to the folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
