skysiders commented on PR #3478:
URL: https://github.com/apache/storm/pull/3478#issuecomment-1123966034

   > It would be nice to move this functionality into some helper for common 
code - something lik e createDirWithPermissions(). But it's ok as is.
   
   Hi @agresch ,Thanks for your review. I think it's better to check permission 
after set special permission.But not all permission is `special` such as 644 or 
755. So if we move this function into some helper for common code perhaps make 
some misuse for others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to