bipinprasad commented on code in PR #3479: URL: https://github.com/apache/storm/pull/3479#discussion_r879740266
########## external/storm-hbase/src/test/java/org/apache/storm/hbase/state/HBaseKeyValueStateProviderTest.java: ########## @@ -21,60 +21,51 @@ import java.util.HashMap; import java.util.Map; import org.apache.storm.Config; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; /** * Unit tests for {@link HBaseKeyValueStateProvider} */ public class HBaseKeyValueStateProviderTest { @Test - public void testConfigHBaseConfigKeyIsEmpty() throws Exception { + public void testConfigHBaseConfigKeyIsEmpty() { HBaseKeyValueStateProvider provider = new HBaseKeyValueStateProvider(); Map<String, String> stormConf = new HashMap<>(); stormConf.put(Config.TOPOLOGY_STATE_PROVIDER_CONFIG, "{\"keyClass\":\"String\", \"valueClass\":\"String\"," + " \"tableName\": \"table\", \"columnFamily\": \"cf\"}"); - try { - HBaseKeyValueStateProvider.StateConfig config = provider.getStateConfig(stormConf); - fail("IllegalArgumentException is expected here."); - } catch (IllegalArgumentException e) { - assertTrue(e.getMessage().contains("hbaseConfigKey")); - } + IllegalArgumentException e = Review Comment: Is this assignment required? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org