bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879788982
##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java:
##########
@@ -72,24 +73,17 @@ public class AvroGenericRecordBoltTest {
private static Schema schema2;
private static Tuple tuple1;
private static Tuple tuple2;
- @Rule
- public MiniDFSClusterRule dfsClusterRule = new MiniDFSClusterRule(() -> {
- Configuration conf = new Configuration();
- conf.set("fs.trash.interval", "10");
- conf.setBoolean("dfs.permissions", true);
- File baseDir = new File("./target/hdfs/").getAbsoluteFile();
- FileUtil.fullyDelete(baseDir);
- conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
baseDir.getAbsolutePath());
- return conf;
- });
+
+ @RegisterExtension
+ public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
Review Comment:
This needs a config supplier as parameter to constructor (with config values
as specified in the Rule)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
