bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220291317
##########
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##########
@@ -164,6 +168,7 @@ public SchedulingResult schedule(Cluster cluster,
TopologyDetails td) {
//order executors to be scheduled
List<ExecutorDetails> orderedExecutors =
execSorter.sortExecutors(unassignedExecutors);
+ isolateAckersToEnd(orderedExecutors);
Review Comment:
This is refactoring. This reordering was earlier being done in
scheduleExecutorsOnNodes(). But it should be done when the executors are
sorted. Then Round Robin strategy to can override scheduleExecutorsOnNodes()
and still receive the executors sorted in right order (i.e. ackers at the end)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
