[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

[via GitHub]

bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220355853


##########
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##########
@@ -527,13 +538,13 @@ protected SchedulingResult 
scheduleExecutorsOnNodes(List<ExecutorDetails> ordere
             if (execIndex == 0) {
                 break;
             } else {
-                searcherState.backtrack(execToComp, nodeForExec[execIndex - 
1], workerSlotForExec[execIndex - 1]);

Review Comment:
   This method signature was changed to backtrack correctly in the presence of 
Acker executors. I believe this is Ray's change that did not make it to 
community earlier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org