Looks like eclipse (Also IntelliJ) doesn’t know about the relocated (shaded)
class. Solution that I have used is to build Storm-shaded-deps directly in
maven (mvn install), and then closing the storm-shaded-deps subproject in
eclipse/IntelliJ. This forces the IDE to use the storm-shaded-jar from -/.m2
and errors go away.
Sent from Yahoo Mail for iPhone
On Wednesday, August 30, 2023, 8:19 PM, Alexandre Vermeerbergen
<avermeerber...@gmail.com> wrote:
Hello;
I have created a branch in my own fork of storm Github projet, and
merged Bipin's changes from these two branches on his own fork:
[STORM-3963] Add m2e plugin to storm-shaded-deps and few minor
pom.xml fixes => remotes/origin/storm-3963 =>
storm-shaded-deps/pom.xml
[STORM-3967] Specify generated sources directory
=> remotes/origin/storm-3967 => pom.xml
I cleaned everything that I previously had in Eclipse, then I tried to
again create an blank Eclipse workspace, then, using Eclipse's import
projects... / Maven / Existing Maven Projects and point to the root
directory of my local Storm git directory.
Maybe one interesting point at this step is that I leave everything
selected by default "as is", including the "[x} Add project(s) to
working set", with "storm" as the associated value.
then I clic on "Finish".
After certain time of processing/downloading dependencies, Eclipse
shows me the "Discover m2e connectors" dialog with same list as in my
initial post, with again, no matter what I select, there is no way to
use "Finish" button
=> from here, clicking "on cancel", brings me to Eclipse IDE showing
tons of errors in the various storm projects created by the import
process.
first one is the following line:
/storm-server/src/main/java/org/apache/storm/zookeeper/AclEnforcement.java
The errors are because the following imports are not found:
import org.apache.storm.shade.org.apache.curator.framework.CuratorFramework;
import org.apache.storm.shade.org.apache.zookeeper.KeeperException;
import org.apache.storm.shade.org.apache.zookeeper.ZooDefs;
import org.apache.storm.shade.org.apache.zookeeper.data.ACL;
import org.apache.storm.shade.org.apache.zookeeper.data.Id;
import
org.apache.storm.shade.org.apache.zookeeper.server.auth.DigestAuthenticationProvider;
It is like storm-shaded-deps's pom.xml was not automatically
generating the shared dependencies for storm-server module.
Any idea what to do next ?
Reminder, I'm using latest Eclipse IDE stable version:
Eclipse IDE for Java Developers (includes Incubating components)
Version: 2023-06 (4.28.0)
Build id: 20230608-1333
Kind regards,
Alexandre
Le mer. 30 août 2023 à 03:35, Richard Zowalla <r...@apache.org> a écrit :
>
> I think you can fork the project, merge Bipin's changes and test with
> Eclipse locally. If the changes solve the issues, it might be a good
> thing otherwise we need to ensure, Eclipse users have a chance to be
> onboarded :)
>
> Am Dienstag, dem 29.08.2023 um 23:14 -0400 schrieb Alexandre
> Vermeerbergen:
> > Hello Julien,
> >
> > Here's the precise version of Eclipse IDE which I am using:
> > ======================================================
> > Eclipse IDE for Java Developers (includes Incubating components)
> >
> > Version: 2023-06 (4.28.0)
> > Build id: 20230608-1333
> > =======================================================
> >
> > And here are the versions of my M2E - Maven Integration for Eclipse's
> > components:
> > Eclipse.org - m2e M2E Maven Integration for Eclipse Core
> > 2.1.2.20230523-2106 org.eclipse.m2e.logback.feature
> > Eclipse.org - m2e M2E Maven Integration for Eclipse Core
> > 2.3.0.20230523-2033 org.eclipse.m2e.feature
> >
> >
> > Unlike Binpin, I can wait forever, the tons of compile issues are
> > still there.
> >
> > I have seen that Binpin is currently doing a pull request to importe
> > stuff in Storm's pom.xml files, maybe should I wait until this is
> > merged to master and then re-try ?
> >
> > Kind regards,
> > Alexandre
> >
> > Le mar. 29 août 2023 à 05:39, Julien Nioche
> > <lists.digitalpeb...@gmail.com> a écrit :
> > >
> > > Hi Alexandre
> > >
> > > I use Eclipse and have imported Storm with Import -> Existing Maven
> > > project
> > > etc.. but am not getting the error message you mentioned. Which
> > > version of
> > > Eclipse are you using?
> > > I then get tons of compilation errors, like you do.
> > >
> > > Julien
> > >
> > >
> > > On Mon, 28 Aug 2023 at 02:23, Alexandre Vermeerbergen <
> > > avermeerber...@gmail.com> wrote:
> > >
> > > > Hello,
> > > >
> > > > I am trying to use my Eclipse IDE to work on a contribution on
> > > > storm
> > > > project.
> > > >
> > > > I must be missing something, because I though I was just a matter
> > > > of
> > > > using Eclipse's import projects... / Maven / Existing Maven
> > > > Projects
> > > > and point to the root directory of my local Storm git directory.
> > > >
> > > > But this import project wizard shows me a 'Setup Maven plugin
> > > > connectors' dialog with the following table, having two columns:
> > > > "Maven Build" and "Action" and 9 lines.
> > > >
> > > > Here are the 2 first lines in JSON:
> > > >
> > > > [{"Maven
> > > > Build":"build-helper-maven-plugin:1.5:add-
> > > > source","Action":"install
> > > > buildhelper"},
> > > > {"Maven Build":"clojure-maven-plugin:1.8.4:compile","Action":"Use
> > > > Workspace Default"}]
> > > >
> > > > and from there I cannot click on Finish button, no matter what I
> > > > try.
> > > >
> > > > If I close this dialog, Eclipse seem to have imported all
> > > > sources, but
> > > > I get tons of compilation errors, like the ones related to
> > > > missing
> > > > shaded packages, such as:
> > > >
> > > > import org.apache.storm.shade.org
> > > > .apache.curator.framework.CuratorFramework;
> > > > import
> > > > org.apache.storm.shade.org.apache.zookeeper.KeeperException;
> > > > import org.apache.storm.shade.org.apache.zookeeper.ZooDefs;
> > > > import org.apache.storm.shade.org.apache.zookeeper.data.ACL;
> > > > import org.apache.storm.shade.org.apache.zookeeper.data.Id;
> > > > import org.apache.storm.shade.org
> > > > .apache.zookeeper.server.auth.DigestAuthenticationProvider;
> > > >
> > > > Sorry if that sounds trivial to current Storm developers, but I'm
> > > > confused what to do to get a "clean" Eclipse workspace to start
> > > > contributing ; and I once I will have understood (which you help,
> > > > you
> > > > Storm developers who already solved that kind of issue) I will
> > > > document this in Contributing page.
> > > >
> > > > Kind regards,
> > > > Alexandre
> > > >
> > >
> > >
> > > --
> > >
> > > *Open Source Solutions for Text Engineering*
> > >
> > > http://www.digitalpebble.com
> > > http://digitalpebble.blogspot.com/
> > > #digitalpebble <http://twitter.com/digitalpebble>
>
