Hi Elisey, Thanks for your email and great to hear that you'd be happy to contribute the code. I am CCing the Storm dev list so that our discussion is in the open and members of the community can contribute to it.
For the people on dev@, Elisey is the author of the Storm images on Docker <https://hub.docker.com/_/storm> that many of us in the community have been using, let's thank him for that! See my message with him below as well as STORM-4014 <https://issues.apache.org/jira/browse/STORM-4014> @Elisey - we might need you to sign a contributor agreement <https://www.apache.org/licenses/contributor-agreements.html> beforehand and ideally change the license to be ASF v2. Would that be OK? I initially thought we'd have the Docker files as part of the Storm repo but maybe it would be simpler to have a separate repository for it and copy the whole git history from your repository. We already have the following on Dockerhub -> https://hub.docker.com/repository/docker/apache/storm/general, not sure how that would work with the 'official images'. Cheers Julien On Fri, 5 Jan 2024 at 12:00, Elisey Zanko <elisey.za...@gmail.com> wrote: > Hi Julien, > > I’d be happy to contribute the image! > Especially because I no longer actively use it myself and don’t have much > time to maintain it. > > If you haven’t seen it already I’d suggest you to have a look at > “Maintainership” section of the Docker Official Images repo: > https://github.com/docker-library/official-images#maintainership > > From that doc I think the most important part is: > > > When taking over an existing repository, please ensure that the entire > Git history of the original repository is kept in the new > upstream-maintained repository to make sure the review process isn't > stalled during the transition. > > Let me know how would you prefer to transfer the repo to the upstream > (e.g., fork, copy commits or move ownership). > > Once transferred we’ll need to create a commit to > https://github.com/docker-library/official-images/blob/master/library/storm > to update image maintainers and git repo. > > Thanks, > Elisey > > > On 4 Jan 2024, at 19:56, Julien Nioche <jul...@digitalpebble.com> wrote: > > > > Hi Elisey, > > > > Happy New Year! > > > > I am a committer on the Apache Storm project and have been using the > images you created and maintained for a while, in particular for my own > project StormCrawler. So a massive thank you for that, I am very grateful > for your work! > > > > We've recently had a discussion about handling the Docker images within > the project. We could of course start from scratch but given that you have > built them, I was wondering whether you would consider contributing them to > the project? > > > > Given that your files are under MIT, I assume it would also be an option > to copy them over to Storm along with the license. > > > > Looking forward to hearing your thoughts on this. > > > > Kind regards > > > > -- > > Julien Nioche > > Director > > > > > > digitalpebble.com > >
