Scomocouk opened a new pull request, #3614:
URL: https://github.com/apache/storm/pull/3614

   ## What is the purpose of the change
   
   Fixes STORM-4017 I raised recently so that isAnyWindowsProcessAlive works 
correctly in Windows.
   What prompted this was that we are evaluating Storm 2.5.0 under Windows and 
noticed that when workers are restarted the child processes are left running.
   We noticed logs reporting that "None of the processes <pid1>, <pid2>, <pid3> 
are alive" when they were in fact still running.
   Further investigation showed why this was happening, hence raised STORM-4017
   
   ## How was the change tested
   
   Existing unit test 'testIsAnyProcessAlive' in ServerUtilsTest.java did not 
work under Windows but now does with this fix.
   
   We have confirmed that we only now see the "None of the processes ... are 
alive" when the processes are genuinely not running
   
   See attached unit test run before and after fix
   
![STORM-4017-not-fixed](https://github.com/apache/storm/assets/152920539/079c08e5-7062-4da3-b78b-001ba211301d)
   
![STORM-4017-fixed](https://github.com/apache/storm/assets/152920539/39f69296-decc-4119-8b73-d17c732539bf)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to