rzo1 commented on code in PR #3642:
URL: https://github.com/apache/storm/pull/3642#discussion_r1650506096
##########
storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java:
##########
@@ -162,6 +163,8 @@ public class Client extends ConnectionWithStatus implements
ISaslClient {
launchChannelAliveThread();
scheduleConnect(NO_DELAY_MS);
int messageBatchSize =
ObjectReader.getInt(topoConf.get(Config.STORM_NETTY_MESSAGE_BATCH_SIZE),
262144);
+ pendingMessagesFlushTimeoutMs =
ObjectReader.getLong(topoConf.get(Config.STORM_MESSAGING_NETTY_FLUSH_TIMEOUT_MS));
Review Comment:
Should we define a default value here, if the config value is not (yet)
updated (in legacy deployments for ex):
```
pendingMessagesFlushTimeoutMs =
ObjectReader.getLong(topoConf.get(Config.STORM_MESSAGING_NETTY_FLUSH_TIMEOUT_MS,
600000L));
```
##########
storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java:
##########
@@ -69,8 +69,9 @@
* destination is currently unavailable.
*/
public class Client extends ConnectionWithStatus implements ISaslClient {
- private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
- private static final long PENDING_MESSAGES_FLUSH_INTERVAL_MS = 1000L;
+ private final long pendingMessagesFlushTimeoutMs ;
+ private final long pendingMessagesFlushIntervalMs;
+ private final double pendingMessagesFlushFactor = 0.0016;
Review Comment:
Should we make this configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
