reiabreu commented on code in PR #3642:
URL: https://github.com/apache/storm/pull/3642#discussion_r1650779375
##########
storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java:
##########
@@ -69,8 +69,9 @@
* destination is currently unavailable.
*/
public class Client extends ConnectionWithStatus implements ISaslClient {
- private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
- private static final long PENDING_MESSAGES_FLUSH_INTERVAL_MS = 1000L;
+ private final long pendingMessagesFlushTimeoutMs ;
+ private final long pendingMessagesFlushIntervalMs;
+ private final double pendingMessagesFlushFactor = 0.0016;
Review Comment:
I've considered that, but feels like it's an implementation detail. I tried
to keep the original logic as much as possible, where the thread would sleep
for 1 second inside a loop that would take 600 seconds in the worst case
scenario, hence the 1/600. It will expose some complexity to the configurations
without a great gain, since the most important configuration is the maximum
amount of time the retry will take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
