rzo1 commented on issue #1588: URL: https://github.com/apache/stormcrawler/issues/1588#issuecomment-3695781751
Thanks for the reference. In our case, the number of metadata entries is normally limited (typically well below ~100 keys), so the practical impact of moving from O(1) to O(log N) is negligible, imho. Given such small N, I don’t think time complexity is a meaningful consideration here, and prioritizing correctness and clarity over (theoretical performance) seems reasonable to me. From my POV we can change the behaviour of `Metadata`, but this is open to discussion. If we opt to introduce an additional class `CaseInsensitiveMetadata`, we need an option to configure it (either programmatically by the implemeting user _or_ via SC's configuration). WDYT @jnioche @sebastian-nagel @mvolikas @sigee ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
