sigee commented on issue #1588: URL: https://github.com/apache/stormcrawler/issues/1588#issuecomment-3708052713
Hi, It was a while ago when I changed the MetadataFilter and I also noticed the inconsistency in the case sensitivity. This is the whole reason behind this issue. In HTML there is no diffrence between lower or uppercase, so it would be nice if Metadata worked in the case insensitive way in my opinion. the mentioned inconsistency in the getValues/containsKey and the addValues/remove kind of handles it under the hood, but not properly. You can add any key in any case, but when you check or get the values it does not matter what cases did you add. Unfortunatelly there is some prefferences as you mentioned by checking exactly before checking case insesitivly. So I think it could be everywhere case insensitive, but I'm not sure what can go wrong because of it. Or how should it be done in an efficient way. Personaly I do not like the new CaseInsensitiveMetadata idea, because as far as I know, there sould not be anything else, just case insensitive one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
