If one set has placeholders then they are ideally not duplicates right ?

For exact duplicates would having a git post-commit hook be a solution ?


On Wed, Aug 20, 2014 at 11:46 AM, Nirmal Fernando <nirmal070...@gmail.com>
wrote:

> I think we have to maintain it in two places otherwise if the file isn't
> there in the product distribution, product would fail to start and also
> since we're using place holders in the config files inside the installer,
> some of those could cause failures when parsing the XML.
>
>
> On Wed, Aug 20, 2014 at 11:36 AM, Dinesh Bandara <dine...@wso2.com> wrote:
>
>> On Wed, Aug 20, 2014 at 11:00 AM, Gayan Gunarathne <gay...@wso2.com>
>> wrote:
>>
>>> Do we recommend to use the Stratos product build itself without using
>>> the Stratos installer?
>>>
>> yes. If we configure and start stratos manually, that process will not
>> use configuration files which are inside stratos installer.
>>
>>>
>>>
>> If we recommed to use the Stratos installer every time,IMO we can
>>> maintain the config in separately in stratus installer and in setup time we
>>> can add them appropriately.
>>>
>>> Thanks,
>>> Gayan
>>>
>>>
>>> On Wed, Aug 20, 2014 at 10:34 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> We have duplicates some product configurations files, one inside
>>>> product and one in stratos-installer. At the boot time (when setup.sh is
>>>> executed) config files inside products will be replaced by the config files
>>>> inside stratos-installer.
>>>> Maintaining duplicate config files become an overhead when a parameter
>>>> is added to the config files in the product, it has to be added to the
>>>> other copy as well. Otherwise it may be missing at deployment time. This
>>>> occurred for expiryTimeout recently in autoscaler.xml
>>>>
>>>> Possible solutions:
>>>> Replicate the changes as we do now,
>>>> Maintain only the config file in stratos-installer
>>>>
>>> +1 to having all configurations in startos installer and referred those
>> when building product. But this will provide the control over only for the
>> configuration files which are used only in startos components not for files
>> such as carbon.xml, etc. If so we have to keep duplicates for those
>> (non-stratos config files)
>>
>> or any other idea?
>>>>
>>>> --
>>>>
>>>> Udara Liyanage
>>>> Software Engineer
>>>> WSO2, Inc.: http://wso2.com
>>>> lean. enterprise. middleware
>>>>
>>>> web: http://udaraliyanage.wordpress.com
>>>> phone: +94 71 443 6897
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gay...@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> *Dinesh Bandara*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Shiroshica Kulatilake

Architect,
WSO2, Inc. http://wso2.com/
Phone: +94 776523867

Reply via email to