Hi, +1 for comment java agent from components/pom.xml.
Thanks ! On Sat, Dec 6, 2014 at 9:37 PM, Rajkumar Rajaratnam <rajkum...@wso2.com> wrote: > Hi, > > I updated the java agent as well. > > However, I would like to point out one more thing. > > Since we are not using java agent, people will make changes to java agent > just for the sake of compiling. No one is testing java agent's functionally. > > If we continue to do this, java agent will be nothing but a garbage in > future. > > At least, we should comment the java agent from components/pom.xml so that > we can avoid build failures and we can keep a stable java agent. > > We all know that we can always go back and checkout a tag/commit and get > the java agent :) > > However, it is just my thought. > > Thanks > > On Sat, Dec 6, 2014 at 9:19 PM, Chamila De Alwis <chami...@wso2.com> > wrote: > >> Hi, >> >> IMO if we're not updating the Java based agent to accommodate the new >> changes, there no point in keeping it in the code base, since we will not >> be able to revert to it. So if we're keeping it there will be the burden of >> maintaining it. >> >> >> Regards, >> Chamila de Alwis >> Software Engineer | WSO2 | +94772207163 >> Blog: code.chamiladealwis.com >> >> >> >> On Fri, Dec 5, 2014 at 2:21 PM, Rajkumar Rajaratnam <rajkum...@wso2.com> >> wrote: >> >>> Hi all, >>> >>> So if we some changes to other components such as topology, do we have >>> to fix the corresponding changes in java agent also? >>> >>> Or can we comment java agent component from components/pom xml to avoid >>> build failures? >>> >>> Thanks. >>> >>> On Fri, Dec 5, 2014 at 2:17 PM, Lakmal Warusawithana <lak...@wso2.com> >>> wrote: >>> >>>> >>>> >>>> On Fri, Dec 5, 2014 at 2:16 PM, Isuru Perera <isu...@wso2.com> wrote: >>>> >>>>> Yes, remove the Java agent in a future release, not in immediate >>>>> release. >>>>> >>>> >>>> +1 >>>> >>>> >>>>> >>>>> On Fri, Dec 5, 2014 at 2:12 PM, Akila Ravihansa Perera < >>>>> raviha...@wso2.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Fri, Dec 5, 2014 at 12:57 PM, Rajkumar Rajaratnam < >>>>>> rajkum...@wso2.com> wrote: >>>>>> >>>>>>> Yeah, let's remove the java agent from our code base. >>>>>>> >>>>>> >>>>>> I'm -1 on removing Java agent code. We can deprecate it for now. >>>>>> Perhaps the need might arise in future. >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, Dec 5, 2014 at 12:07 PM, Lakmal Warusawithana < >>>>>>> lak...@wso2.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Dec 5, 2014 at 11:56 AM, Rajkumar Rajaratnam < >>>>>>>> rajkum...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> While doing topology changes, noticed that the java agent is still >>>>>>>>> there in code base. >>>>>>>>> >>>>>>>>> If we are not maintaining, we can remove this component from the >>>>>>>>> code base right? >>>>>>>>> >>>>>>>>> Otherwise, we have to maintain it properly. >>>>>>>>> >>>>>>>>> wdyt? >>>>>>>>> >>>>>>>> >>>>>>>> IMO, we should only go with python agent. >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Rajkumar Rajaratnam >>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>> Software Engineer, WSO2 >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Lakmal Warusawithana >>>>>>>> Vice President, Apache Stratos >>>>>>>> Director - Cloud Architecture; WSO2 Inc. >>>>>>>> Mobile : +94714289692 >>>>>>>> Blog : http://lakmalsview.blogspot.com/ >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Rajkumar Rajaratnam >>>>>>> Committer & PMC Member, Apache Stratos >>>>>>> Software Engineer, WSO2 >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Akila Ravihansa Perera >>>>>> Software Engineer, WSO2 >>>>>> >>>>>> Blog: http://ravihansa3000.blogspot.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Isuru Perera >>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >>>>> Lean . Enterprise . Middleware >>>>> >>>>> about.me/chrishantha >>>>> >>>> >>>> >>>> >>>> -- >>>> Lakmal Warusawithana >>>> Vice President, Apache Stratos >>>> Director - Cloud Architecture; WSO2 Inc. >>>> Mobile : +94714289692 >>>> Blog : http://lakmalsview.blogspot.com/ >>>> >>>> >>> >>> >>> -- >>> Rajkumar Rajaratnam >>> Committer & PMC Member, Apache Stratos >>> Software Engineer, WSO2 >>> >> >> > > > -- > Rajkumar Rajaratnam > Committer & PMC Member, Apache Stratos > Software Engineer, WSO2 > -- Regards, Manula Chathurika Thantriwatte Software Engineer WSO2 Inc. : http://wso2.com lean . enterprise . middleware email : manu...@wso2.com / man...@apache.org phone : +94 772492511 blog : http://manulachathurika.blogspot.com/
