Hi Martin,

Thanks for identifying this, yes it seems like a bug. Gayan did we test
this?

IMO we need to compare the Application ID sent in the Application SignUp
Removal event against the Application ID in the payload, then if the
tenant's Git repository is already cloned we need to remove it.

Thanks

On Wed, Feb 18, 2015 at 3:06 AM, Martin Eppel (meppel) <mep...@cisco.com>
wrote:

>  In extensionhandler.py we compare in “
> *on_application_signup_removal_event*” method service_name with
> applicationId, is this a bug or intentional ?
>
>
>
> See snippet:
>
>
>
>
>
> def on_application_signup_removal_event(self,
> application_signup_removal_event):
>
>         self.log.info(
>
>             "Tenant unsubscribed event received: [tenant] " +
> application_signup_removal_event.tenantId +
>
>             " [application ID] " +
> application_signup_removal_event.applicationId
>
>         )
>
>
>
>         *if self.cartridge_agent_config.service_name ==
> application_signup_removal_event.applicationId:*
>
>
> agentgithandler.AgentGitHandler.remove_repo(application_signup_removal_event.tenant_id)
>
>
>
>         extensionutils.execute_application_signup_removal_extension({})
>



-- 
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Reply via email to