Hi Martin, Yes, I've branched off from the latest master, and rebase frequently. I assume you're referring to the commit related to ApplicationSignUpEvent in the JCA? I have those changes in my branch.
Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Sat, Feb 21, 2015 at 3:15 AM, Martin Eppel (meppel) <mep...@cisco.com> wrote: > Hi Chamila, > > > > Great to hear that. > > > > Quick question – I assume you are basing your improvements on the latest > code from master (fyi, I added a few of the missing “differences” to the > JCA in master) ?, > > > > Thanks > > > > Martin > > > > *From:* Chamila De Alwis [mailto:chami...@wso2.com] > *Sent:* Friday, February 20, 2015 1:36 PM > *To:* dev > *Subject:* [Discuss] Java Cartridge Agent Improvements > > > > Hi, > > > > I'm in the process of getting the JCA to a matching state with the PCA. As > a part of this I copied over the integration test that was written by Imesh > for the PCA, to simplify error checks and find bugs in the JCA. > > > > There was an issue in the CartridgeEventListener where > TopologyManager.acquireReadLock() was called after a conditional return > statement. The lock is released in the finally{} block and thus it executes > before the return statement completes, i.e. before actually acquiring the > lock. > > > > Another issue I've found so far is the -Dthrift.client.config.file.path > system property and the thrift-client-config.xml being missing in the > Cartridge agent product assembly. > > > > I will soon submit a PR with a stable JCA. > > > > Any feedback, ideas are appreciated! :) > > > > Regards, > > Chamila de Alwis > > Software Engineer | WSO2 | +94772207163 > > Blog: code.chamiladealwis.com > > > > >
