Hi Devs, Some of the PMC Members got together and held a code review for the $subject. Following are the details of code review for the pull request 270. Please feel free to add your comments.
Pull Request No :- 270 Attendees :- Imesh Gunaratne Lahiru Sandaruwan Isuru Haththotuwa Chamila De Alwis Dinithi De Silva Vishanth Balasubramaniam Anuruddha Liyanarachchi Changes Identified - CLI needs a method to print tree-type data structure. - Validate and generate all the comment using IDE. - Add a single method to print strings and JSON values. ( Using Pretty Print ) - Test the commands of CLI in non interactive method. - Refactoring Logger object variable names RestCommandLineService.java line no 1776 : Remove the list ==null condition that is repeated. line no 1773 : Exceeds the 120 text per line limit. line no 1796 : No of network partitions, N should be lower case line no 1816 : Change the parameter name to policyId Refine the endpoint resources variables to remove duplicated constants AddApplicationPolicyCommand.java line no 67 : Parameter Name already_parsed_opts should be changed according to java standards. line no 95 : Use printUsage method instead of sysout. line no 126 : Replace ‘\n’ with system property DescibeApplicationPolicyCommand.java Correct the spelling of the class name. -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a <thili...@wso2.com>nurudd...@wso2.com
