Hi Shaheed, I think your fix is valid. properties variable is not initialized before adding property. I will commit the fix. Thanks for suggesting the fix.
On Wed, Mar 25, 2015 at 3:43 PM, Shaheedur Haque (shahhaqu) < [email protected]> wrote: > Hi all, > > > > With master at 69a5eb from a few hours ago, and the following temporary > fix: > > > > $ git diff > > diff --git > a/components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/domain/Cartridge.ja > > index 4c1a690..5072dcd 100644 > > --- > a/components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/domain/Cartridge.java > > +++ > b/components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/domain/Cartridge.java > > @@ -78,6 +78,7 @@ public class Cartridge implements Serializable{ > > > > private void init() { > > tenantPartitions = "*"; > > + properties = new org.apache.stratos.common.Properties(); > > } > > > > public String getType() { > > > > I can now see volumes being attached correctly. So, pending an official > version of the above fix, I will consider this issue as closed form my POV. > > > > Thanks, Shaheed > > > > *From:* Imesh Gunaratne [mailto:[email protected]] > *Sent:* Saturday, March 14, 2015 5:59 AM > *To:* dev > *Subject:* Re: Schema changes for Stratos 4.1 > > > > Hi Devs, > > > > Thanks Shaheed for brining this up. @Devs I think we need to add the > persistence attribute to the Subscribable information section and implement > any logic required in the backend. > > > > Thanks > > > > On Fri, Mar 13, 2015 at 9:26 PM, Shaheedur Haque (shahhaqu) < > [email protected]> wrote: > > Imesh and I discussed this, and it was agreed that this seems to be > missing. Imesh undertook to investigate and report back. > > > > *From:* Shaheedur Haque (shahhaqu) > *Sent:* 12 March 2015 16:23 > *To:* [email protected] > *Subject:* Schema changes for Stratos 4.1 > > > > Hi Imesh, > > > > I’m busy porting our code to the new model. One issue I have just come > across is that in the old model, the “persistence” attribute was available > (as I understand it) on both the Cartridge Definition and also on the > Cartridge Subscription. For reasons I am sure you will understand, we must > apply the attribute on the Subscription. I don’t quite see how/where to do > this in the new model. Have I missed something? > > > > Also, this begs the question whether there are any other attributes on the > old Subscription that have not made it into the new model. It would > probably be a good idea to a quick/urgent review of this using the > comparison document you published…WDYT? > > > > Finally, did you see my comment on the comparison doc about the > cartridgeMin/Max values? > > > > Thanks, Shaheed > > > > > > > > -- > > Imesh Gunaratne > > > > Technical Lead, WSO2 > > Committer & PMC Member, Apache Stratos > -- Udara Liyanage Software Engineer WSO2, Inc.: http://wso2.com lean. enterprise. middleware web: http://udaraliyanage.wordpress.com phone: +94 71 443 6897
