Hi all, Thanks for the feedback.
On Wed, Apr 29, 2015 at 6:07 PM, Chamila De Alwis <chami...@wso2.com> wrote: > Hi Isuru, > > Great work! This was a necessity for a long time. IMO we should have an > approach to samples where the real world scenarios or closer to real world > scenarios are used for samples. For example we should keep the "tomcat" > sample and remove the "single-cartridge-app" if both are same. The README > would describe what sample scenario it covers. > Agreed that we should have samples closer to real world scenarios, such as the wordpress application which we have currently. However, IMHO an application with a single tomcat cartridge does not really showcase how composite applications would support such scenarios. That was possible with Stratos 4 subscription model as well. Therefore, for such scenarios we should provide generic applications, so that anyone can use them as a guideline and create their own simple applications, tomcat, php, or anything else. That is why I thought of keeping single-cartridge-app without specifically tomcat. > > > > Regards, > Chamila de Alwis > Software Engineer | WSO2 | +94772207163 > Blog: code.chamiladealwis.com > > > > On Wed, Apr 29, 2015 at 3:56 PM, Reka Thirunavukkarasu <r...@wso2.com> > wrote: > >> +1 for using the directory structure for the samples. In that way, anyone >> can find out relevant samples easily without looking into the >> application/group. >> >> Can we add a category for startupDependents, termination behavior >> (terminate-all and terminate-dependent) as well? >> > +1 > >> Thanks. >> Reka >> >> On Wed, Apr 29, 2015 at 3:33 PM, Isuru Haththotuwa <isu...@apache.org> >> wrote: >> >>> Hi Devs, >>> >>> I started looking in to $subject. Please find the initial findings: >>> >>> *Application Name* >>> >>> *Proposed New Name (if required)* >>> >>> *Comments* >>> >>> *Can Remove?* >>> >>> single-cartridge >>> >>> single-cartridge-app >>> >>> - >>> >>> >>> tomcat >>> >>> - >>> >>> duplicate single cartridge app, can be removed >>> >>> Yes >>> >>> single-group-cartridge >>> >>> single-group-app >>> >>> - >>> >>> >>> single-group-v3 >>> >>> >>> only difference is from single-group-cartridge is there are multiple >>> group instances, should remove IMO >>> >>> Yes >>> >>> nested-group >>> >>> single-level-nested-group-app >>> >>> - >>> >>> >>> nested-group-v2 >>> >>> >>> only difference with nested-group is there are multiple groups nested >>> at level1; can either remove, or else can rename to >>> single-level-nested-groups-app >>> >>> Yes >>> >>> complex-app >>> >>> single-level-nested-groups-app >>> >>> - >>> >>> >>> wordpress >>> >>> wordpress-app >>> >>> - >>> >>> >>> wordpress-extended-v1 >>> >>> - >>> >>> in addition to wordpress sample, an additional tomcat cartridge in >>> included in this app, can remove IMO >>> >>> Yes >>> >>> wordpress-extended-v2 >>> >>> - >>> >>> in addition to wordpress sample, an additional tomcat cartridge in >>> included in this app and min group instance count is 2, can remove IMO >>> >>> Yes >>> >>> group-cartridges >>> >>> - >>> >>> redundant, can be removed >>> >>> Yes >>> >>> n-level-nesting >>> >>> five-levels-nested-groups-app >>> >>> this is an extreme scenario for even a complex app >>> >>> >>> esb-php-nested-with-esb-php-nested-with-mysql-php-app >>> >>> >>> Does this app has any real use case? If not, can remove. >>> >>> >>> single-group-v1 >>> >>> - >>> >>> Redundant, can be removed >>> >>> Yes >>> >>> single-group-v2 >>> >>> - >>> >>> Redundant, can be removed >>> >>> Yes >>> >>> more-complex-app >>> >>> - >>> >>> Redundant, can be removed >>> >>> Yes >>> >>> I'm yet to look in to the scaling related samples. >>> >>> Furthermore, IMHO we can re-organize the the samples using a directory >>> structure as shown below: >>> >>> applications >>> -- simple (this will carry single cartridge apps, and apps with >>> non nested groups) >>> -- nested (complex apps with nested groups) >>> -- scaling (group/dependency scaling, bursting and similar apps >>> with special patterns) >>> >>> Please share your thoughts on this. >>> >>> -- >>> Thanks and Regards, >>> >>> Isuru H. >>> +94 716 358 048* <http://wso2.com/>* >>> >>> >>> >> >> >> -- >> Reka Thirunavukkarasu >> Senior Software Engineer, >> WSO2, Inc.:http://wso2.com, >> Mobile: +94776442007 >> >> -- >> <%2B94776442007> >> <%2B94776442007> >> Thanks and Regards, >> >> Isuru H. >> <%2B94776442007> >> +94 716 358 048 <%2B94776442007>* <http://wso2.com/>* >> >> >> * <http://wso2.com/>* >> >> >>
