Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/296#discussion_r29759953
--- Diff:
components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
---
@@ -453,6 +453,18 @@ public Response addServiceGroup(
if (e.getCause().getMessage().contains("already exists")) {
return
Response.status(Response.Status.CONFLICT).entity(new StatusResponseBean(
Response.Status.CONFLICT.getStatusCode(),
"Cartridge group not found")).build();
+ } else if (e.getCause().getMessage().contains("duplicate
cartridges")) {
--- End diff --
IMO it would be better to use specific exceptions for handling this logic
rather than using different messages.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
