Github user Vishanth commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/296#discussion_r29827227
  
    --- Diff: 
components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java
 ---
    @@ -1188,12 +1180,12 @@ public static void removeServiceGroup(String name) 
throws RestAPIException, Auto
     
                 // Remove the dependent cartridges and cartridge groups from 
Stratos Manager cache
                 // - done after service group has been removed
    -            if (serviceGroup.getCartridges() != null) {
    -                List<String> cartridgeList = new ArrayList<String>();
    -                findCartridgesInServiceGroup(serviceGroup, cartridgeList);
    -                String[] cartridgeNames = cartridgeList.toArray(new 
String[cartridgeList.size()]);
    -                
smServiceClient.removeUsedCartridgesInCartridgeGroups(name, cartridgeNames);
    -            }
    +
    +            List<String> cartridgeList = new ArrayList<String>();
    +            findCartridgesInServiceGroup(serviceGroup, cartridgeList);
    --- End diff --
    
    It is a recursive method to go into groups of groups and add the cartridges 
to the list. Since the same method is called inside the 
findCartridgesInServiceGroup method, a list is passed to add the cartridges 
recursively.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to