Thanks Vishanth. I have merged it now..
Thanks, Reka On Tue, May 19, 2015 at 11:51 AM, Vishanth Balasubramaniam < vishan...@wso2.com> wrote: > Hi, > > I have removed this now. Please merge the PR[1]. > > [1] - https://github.com/apache/stratos/pull/339 > > Regards, > Vishanth > > On Tue, May 19, 2015 at 10:34 AM, Reka Thirunavukkarasu <r...@wso2.com> > wrote: > >> Thanks Imesh for confirming it. So, i will remove this from the Bean for >> this release. >> >> Thanks, >> Reka >> >> On Mon, May 18, 2015 at 7:51 PM, Imesh Gunaratne <im...@apache.org> >> wrote: >> >>> Currently we are constructing the Kubernetes Master Endpoint URL as >>> follows, therefore this is not needed: >>> >>> public KubernetesClusterContext(String id, String masterIp, String >>> masterPort, int lowerPort, int upperPort) { >>> ... >>> this.setKubApi(new KubernetesApiClient(getEndpoint(masterIp, >>> masterPort))); >>> ... >>> } >>> >>> private String getEndpoint(String ip, String port) { >>> return "http://"; + ip + ":" + port + "/api/v1beta1/"; >>> } >>> >>> However IMO in a later release we need to introduce this to support >>> Kubernetes on GCE. Will remove it in this release. >>> >>> Thanks >>> >>> >>> On Mon, May 18, 2015 at 2:13 PM, Reka Thirunavukkarasu <r...@wso2.com> >>> wrote: >>> >>>> Hi >>>> >>>> Is $subject needed? We don't currently display this in UI. If it is >>>> needed, i can do the needful to show it in the UI. If not, i can remove >>>> this from the bean. Please advice.. >>>> >>>> Thanks, >>>> Reka >>>> >>>> -- >>>> Reka Thirunavukkarasu >>>> Senior Software Engineer, >>>> WSO2, Inc.:http://wso2.com, >>>> Mobile: +94776442007 >>>> >>>> >>>> >>> >>> >>> -- >>> Imesh Gunaratne >>> >>> Senior Technical Lead, WSO2 >>> Committer & PMC Member, Apache Stratos >>> >> >> >> >> -- >> Reka Thirunavukkarasu >> Senior Software Engineer, >> WSO2, Inc.:http://wso2.com, >> Mobile: +94776442007 >> >> >> > > > -- > *Vishanth Balasubramaniam* > Software Engineer > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: *+94771737718* > about me: *http://about.me/vishanth <http://about.me/vishanth>* > > -- Reka Thirunavukkarasu Senior Software Engineer, WSO2, Inc.:http://wso2.com, Mobile: +94776442007
