Hi Asanka, Thanks for the PR and updates.In overview this PR looks good.
I have added some comments to the PR itself for minor changes that we can add to improve the code further.Can you please check and update those. Thanks, Gayan On Sat, Aug 8, 2015 at 10:38 AM, Asanka Sanjaya Herath <angal...@gmail.com> wrote: > Hi Isuru, > > I think you are referring to a previous commit. I have changed all those > in later commits. Please refer final changes here [1]. > > [1]. https://github.com/apache/stratos/pull/419/files > > On Sat, Aug 8, 2015 at 10:32 AM, Asanka Sanjaya Herath <angal...@gmail.com > > wrote: > >> Hi Isuru, >> >> Thanks I'll look into it. >> >> On Sat, Aug 8, 2015 at 5:37 AM, Isuru Haththotuwa <isu...@apache.org> >> wrote: >> >>> Hi Asanka, >>> >>> Great work and thanks for the PR. >>> >>> Just glanced at it. There seem to be several places where you have hard >>> coded GCE zones, project ids, etc. where you have added TODOs remove them >>> later. Also, there are places that you are using System.outs to print >>> information. Shall we clean up these? Please check on formatting as well. >>> That will help the community to focus on the functionality, code >>> improvements and detect possible issues. >>> >>> On Fri, Aug 7, 2015 at 1:03 AM, Asanka Sanjaya Herath < >>> angal...@gmail.com> wrote: >>> >>>> I have created the PR [1]. >>>> >>>> [1]. https://github.com/apache/stratos/pull/419 >>>> >>>> On Fri, Aug 7, 2015 at 11:43 AM, Asanka Sanjaya Herath < >>>> angal...@gmail.com> wrote: >>>> >>>>> Hi Gayan, >>>>> >>>>> I'll send the PR today. Sorry for the delay. >>>>> >>>>> On Thu, Aug 6, 2015 at 1:02 PM, Gayan Gunarathne <gay...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Asanka, >>>>>> >>>>>> Once you have done with the above code review changes , please send >>>>>> us the PR for the implementation. >>>>>> >>>>>> Thanks, >>>>>> Gayan >>>>>> >>>>>> On Thu, Jul 30, 2015 at 7:14 PM, Asanka Sanjaya Herath < >>>>>> angal...@gmail.com> wrote: >>>>>> >>>>>>> Code review notes: >>>>>>> >>>>>>> 1. Without throwing run time exceptions always try to handle the >>>>>>> exception >>>>>>> 2. Try to throw more specific exceptions without just throwing >>>>>>> generic exceptions so that will be easy to troubleshoot >>>>>>> 3. Always put generic comments >>>>>>> 4. Add debug log messages >>>>>>> >>>>>>> >>>>>>> On Thu, Jul 30, 2015 at 12:06 PM, Asanka Sanjaya Herath < >>>>>>> angal...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> We had the hangout and demo as we planned. We discussed about >>>>>>>> issues in current code like exception handling commenting etc. And we >>>>>>>> discussed about modifications I did, future plans, limitations in GCE >>>>>>>> like >>>>>>>> domain mapping, statistic publishing etc. >>>>>>>> >>>>>>>> I'm planing to do all the modifications requested in my code and do >>>>>>>> a screen cast again including the changes I have done. >>>>>>>> >>>>>>>> Participants: Stratos Team, Asanka >>>>>>>> >>>>>>>> On Mon, Jul 27, 2015 at 12:16 PM, Asanka Sanjaya Herath < >>>>>>>> angal...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> We are planning to have a hangout in this week for discuss the >>>>>>>>> progress, changes I have made and issues about the GCE LB extension >>>>>>>>> currently I'm working on. It has been scheduled on 30th Thursday at >>>>>>>>> 11 AM >>>>>>>>> IST. >>>>>>>>> >>>>>>>>> On Wed, Jul 22, 2015 at 12:31 PM, Isuru Haththotuwa < >>>>>>>>> isu...@apache.org> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, Jul 21, 2015 at 10:51 PM, Gayan Gunarathne < >>>>>>>>>> gay...@wso2.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Asanka, >>>>>>>>>>> >>>>>>>>>>> We can check further with their forum[1] >>>>>>>>>>> >>>>>>>>>>> Also did you check with the [2]. Seems there are inbuilt health >>>>>>>>>>> checking option.If they don't provide option to get in flight >>>>>>>>>>> request >>>>>>>>>>> count,IMO we can use their inbuilt health checking option. >>>>>>>>>>> >>>>>>>>>>> [1] https://groups.google.com/forum/#!forum/gce-discussion >>>>>>>>>>> [2] >>>>>>>>>>> https://cloud.google.com/compute/docs/load-balancing/health-checks >>>>>>>>>>> >>>>>>>>>> Yes. If GCE API does not provide a way to get this information, >>>>>>>>>> we have to look in to alternate methods. Not sure how the health >>>>>>>>>> check >>>>>>>>>> works here, but maybe its just doing a port check. If so, we won't >>>>>>>>>> be able >>>>>>>>>> to directly use in Autoscaling decision making. But that is fine >>>>>>>>>> IMO, we >>>>>>>>>> can only support what is available. >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Gayan >>>>>>>>>>> >>>>>>>>>>> On Tue, Jul 21, 2015 at 8:22 PM, Asanka Sanjaya Herath < >>>>>>>>>>> angal...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Isuru, >>>>>>>>>>>> >>>>>>>>>>>> Unfortunately I was not able to figure out a way to do this. I >>>>>>>>>>>> really appreciate if you can help me with this. >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Jul 21, 2015 at 8:20 PM, Isuru Haththotuwa < >>>>>>>>>>>> isu...@apache.org> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Asanka, >>>>>>>>>>>>> >>>>>>>>>>>>> On Sat, Jul 18, 2015 at 10:13 AM, Asanka Sanjaya Herath < >>>>>>>>>>>>> angal...@gmail.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks Isuru. Currently I'm fixing an issue related to member >>>>>>>>>>>>>> termination. Meanwhile I'm struggling to find a way to get "in >>>>>>>>>>>>>> flight >>>>>>>>>>>>>> request count" from GCE. I'll do some more research and update >>>>>>>>>>>>>> the thread. >>>>>>>>>>>>>> >>>>>>>>>>>>> Were you able to find a way to get the In Flight Request count >>>>>>>>>>>>> from GCE APIs? Please share your findings. >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Sat, Jul 18, 2015 at 8:33 PM, Isuru Haththotuwa < >>>>>>>>>>>>>> isu...@apache.org> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Great work so far Asanka! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed, Jul 15, 2015 at 6:01 AM, Asanka Sanjaya Herath < >>>>>>>>>>>>>>> angal...@gmail.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks Gayan for the feedback. As we discussed on hangout I >>>>>>>>>>>>>>>> have done some screen recoding about the LB extension that I >>>>>>>>>>>>>>>> have created. >>>>>>>>>>>>>>>> I have published that on YouTube. Here is the link. >>>>>>>>>>>>>>>> https://youtu.be/dAWYQL1Vleo . >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mon, Jul 13, 2015 at 12:25 PM, Gayan Gunarathne < >>>>>>>>>>>>>>>> gay...@wso2.com> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks Asanka for the progress update. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Nice to hear that you are writing the blog on this. Please >>>>>>>>>>>>>>>>> share the blog post once you have done. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Yeah now you can work on the statistic publishing >>>>>>>>>>>>>>>>> part.Also please share us the information about how do you >>>>>>>>>>>>>>>>> plan to gather >>>>>>>>>>>>>>>>> GCE related statistics for your extension. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Gayan >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Mon, Jul 6, 2015 at 6:12 PM, Asanka Sanjaya Herath < >>>>>>>>>>>>>>>>> angal...@gmail.com> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Last week I implemented a way to read configuration from >>>>>>>>>>>>>>>>>> a configuration file instead of reading from system >>>>>>>>>>>>>>>>>> arguments as we >>>>>>>>>>>>>>>>>> discussed in last hangout [1]. And I did some testing >>>>>>>>>>>>>>>>>> related to topology >>>>>>>>>>>>>>>>>> issue and end to end testing as well. I have started writing >>>>>>>>>>>>>>>>>> blog post >>>>>>>>>>>>>>>>>> related to extension as we discussed in last hangout. I'm >>>>>>>>>>>>>>>>>> willing to do the >>>>>>>>>>>>>>>>>> statistics publishing part in this week and I'm supposed to >>>>>>>>>>>>>>>>>> recode a demo >>>>>>>>>>>>>>>>>> too. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> [1]. >>>>>>>>>>>>>>>>>> https://github.com/apache/stratos/commit/d8256222b959721763354e8149a6f975dd8e3d76 >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Jun 29, 2015 at 2:58 PM, Asanka Sanjaya Herath < >>>>>>>>>>>>>>>>>> angal...@gmail.com> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi All, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Last week I was working on debugging, testing and >>>>>>>>>>>>>>>>>>> finding an error related to topology as we discussed in >>>>>>>>>>>>>>>>>>> hangout. After >>>>>>>>>>>>>>>>>>> debugging I opened a discussion thread in dev list in order >>>>>>>>>>>>>>>>>>> to discuss >>>>>>>>>>>>>>>>>>> findings. And I added a timeout for operation completions >>>>>>>>>>>>>>>>>>> [1]. And as we >>>>>>>>>>>>>>>>>>> discussed in hangout I did some changes in message >>>>>>>>>>>>>>>>>>> processor side in order >>>>>>>>>>>>>>>>>>> to expose the instance ID of the member to other components >>>>>>>>>>>>>>>>>>> too [2]. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> [1]. >>>>>>>>>>>>>>>>>>> https://github.com/apache/stratos/commit/9df565f1296707165e96755ca6a0b1c37bea53b1 >>>>>>>>>>>>>>>>>>> [2]. >>>>>>>>>>>>>>>>>>> https://github.com/apache/stratos/commit/9f44791884a54499997a0e5d00f7a4b46047b3b2 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Tue, Jun 23, 2015 at 2:09 PM, Imesh Gunaratne < >>>>>>>>>>>>>>>>>>> im...@apache.org> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Mon, Jun 22, 2015 at 4:00 PM, Asanka Sanjaya Herath >>>>>>>>>>>>>>>>>>>> <angal...@gmail.com> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi All, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> We had the hangout today and we discussed on following. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Participants: IsuruH, GayanG, Imesh, Asanka >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>> Imesh Gunaratne >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Senior Technical Lead, WSO2 >>>>>>>>>>>>>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>>>>> ASH >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>>>> ASH >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Gayan Gunarathne >>>>>>>>>>>>>>>>> Technical Lead, WSO2 Inc. (http://wso2.com) >>>>>>>>>>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>>>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>> ASH >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Thanks and Regards, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Isuru H. >>>>>>>>>>>>>>> +94 716 358 048* <http://wso2.com/>* >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>> ASH >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Thanks and Regards, >>>>>>>>>>>>> >>>>>>>>>>>>> Isuru H. >>>>>>>>>>>>> +94 716 358 048* <http://wso2.com/>* >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Regards, >>>>>>>>>>>> ASH >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> Gayan Gunarathne >>>>>>>>>>> Technical Lead, WSO2 Inc. (http://wso2.com) >>>>>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>>>>> email : gay...@wso2.com | mobile : +94 766819985 >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Thanks and Regards, >>>>>>>>>> >>>>>>>>>> Isuru H. >>>>>>>>>> +94 716 358 048* <http://wso2.com/>* >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks, >>>>>>>>> Regards, >>>>>>>>> ASH >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks, >>>>>>>> Regards, >>>>>>>> ASH >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks, >>>>>>> Regards, >>>>>>> ASH >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Gayan Gunarathne >>>>>> Technical Lead, WSO2 Inc. (http://wso2.com) >>>>>> Committer & PMC Member, Apache Stratos >>>>>> email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Regards, >>>>> ASH >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Regards, >>>> ASH >>>> >>> >>> >>> >>> -- >>> Thanks and Regards, >>> >>> Isuru H. >>> +94 716 358 048* <http://wso2.com/>* >>> >>> >>> >> >> >> -- >> Thanks, >> Regards, >> ASH >> > > > > -- > Thanks, > Regards, > ASH > -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache Stratos email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
