Shall we use tags for CEP and DAS without using an attribute called name?
<thriftClientConfiguration>
<config>
<cep>
<node id="node-01">
<statsPublisherEnabled>true</statsPublisherEnabled>
<username>admin</username>
<password>1234</password>
<ip>192.168.10.10</ip>
<port>9300</port>
</node>
<node id="node-02">
<statsPublisherEnabled>true</statsPublisherEnabled>
<username>admin</username>
<password>12345</password>
<ip>192.168.10.20</ip>
<port>9300</port>
</node>
</cep>
<das>
<node id="node-01">
<statsPublisherEnabled>true</statsPublisherEnabled>
<username>admin</username>
<password>1234</password>
<ip>192.168.10.11</ip>
<port>9300</port>
</node>
</das>
</config>
</thriftClientConfiguration>
On Fri, Oct 9, 2015 at 8:51 PM, Thanuja Uruththirakodeeswaran <
[email protected]> wrote:
>
> On 9 Oct 2015 20:36, "Pubudu Gunatilaka" <[email protected]> wrote:
> >
> > Hi,
> >
> > If we are publishing to multiple nodes, these two formats are not
> suitable. IMO we should come up with a proper format which can support
> multiple nodes. I would suggest following format.
> >
> > =============================================
> > <thriftClientConfiguration>
> > <config>
> > <server name="das">
> > <node id="node-01">
> > <statsPublisherEnabled>true</statsPublisherEnabled>
> > <username>admin</username>
> > <password>1234</password>
> > <ip>192.168.10.10</ip>
> > <port>9300</port>
> > </node>
> > <node id="node-02">
> > <statsPublisherEnabled>true</statsPublisherEnabled>
> > <username>admin</username>
> > <password>12345</password>
> > <ip>192.168.10.20</ip>
> > <port>9300</port>
> > </node>
> > </server>
> > </config>
> > </thriftClientConfiguration>
> >
>
> +1 for the above format as it will support configuring multiple nodes per
> a particular server and having the same format in all components.
>
> Thanks. =============================================
>
> >
> > Thank you!
> >
> > On Fri, Oct 9, 2015 at 7:34 PM, Gayan Gunarathne <[email protected]>
> wrote:
> >>
> >> Seems like we are using the name to identifier the server(CEP or
> DAS). With the load balancer extensions we only publish the data to
> the CEP. That may be the reason we didn't add that name thing. To
> maintain the consistency across the whole code base we can use the same
> config everywhere.
> >>
> >> Thanks,
> >> Gayan
> >>
> >> On Fri, Oct 9, 2015 at 7:02 PM, Sajith Kariyawasam <[email protected]>
> wrote:
> >>>
> >>> Hi Devs,
> >>>
> >>> It seems we have different formats of thrift-client-config.xml file.
> >>>
> >>> For eg,
> >>>
> >>>
> ./products/stratos/modules/distribution/src/main/conf/thrift-client-config.xml
> has following format
> >>>
> >>> =============================================
> >>> <thriftClientConfiguration>
> >>> <config>
> >>> <name>cep</name>
> >>> <statsPublisherEnabled>true</statsPublisherEnabled>
> >>> <username>admin</username>
> >>> <password>1234</password>
> >>> <ip>192.168.10.10</ip>
> >>> <port>9300</port>
> >>> </config>
> >>> <config>
> >>> <name>das</name>
> >>> <statsPublisherEnabled>true</statsPublisherEnabled>
> >>> <username>admin1</username>
> >>> <password>12345</password>
> >>> <ip>192.168.10.11</ip>
> >>> <port>9301</port>
> >>> </config>
> >>> </thriftClientConfiguration>
> >>> =============================================
> >>>
> >>>
> >>>
> ./extensions/load-balancer/modules/haproxy-extension/src/main/conf/thrift-client-config.xml
> has following format
> >>> ================================
> >>> <thriftClientConfiguration>
> >>> <username>admin</username>
> >>> <password>admin</password>
> >>> <ip>localhost</ip>
> >>> <port>7611</port>
> >>> </thriftClientConfiguration>
> >>> =================================
> >>>
> >>> What would be the correct one?
> >>>
> >>> Thanks,
> >>> Sajith
> >>>
> >>>
> >>> --
> >>> Sajith Kariyawasam
> >>> Committer and PMC member, Apache Stratos,
> >>> WSO2 Inc.; http://wso2.com
> >>> Mobile: 0772269575
> >>
> >>
> >>
> >>
> >> --
> >>
> >> Gayan Gunarathne
> >> Technical Lead, WSO2 Inc. (http://wso2.com)
> >> Committer & PMC Member, Apache Stratos
> >> email : [email protected] | mobile : +94 775030545
> >>
> >>
> >
> >
> >
> >
> > --
> > Pubudu Gunatilaka
> > Committer and PMC Member - Apache Stratos
> > Software Engineer
> > WSO2, Inc.: http://wso2.com
> > mobile : +94774079049
> >
>
>
--
Imesh Gunaratne
Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
