Github user Jasintha commented on a diff in the pull request:
https://github.com/apache/stratos/pull/463#discussion_r63987674
--- Diff:
components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/statistics/publisher/ScalingDecisionPublisher.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.stratos.autoscaler.statistics.publisher;
+
+import org.apache.stratos.common.statistics.publisher.StatisticsPublisher;
+
+/**
+ * Scaling Decision Publisher interface.
+ */
+public interface ScalingDecisionPublisher extends StatisticsPublisher {
+ /**
+ * Publishing scaling decision to DAS.
+ *
+ * @param timestamp Scaling Time
+ * @param scalingDecisionId Scaling Decision Id
+ * @param clusterId Cluster Id
+ * @param minInstanceCount Minimum Instance Count
+ * @param maxInstanceCount Maximum Instance Count
+ * @param rifPredicted RIF Predicted
+ * @param rifThreshold RIF Threshold
+ * @param rifRequiredInstances RIF Required Instances
+ * @param mcPredicted MC Predicted
+ * @param mcThreshold MC Threshold
+ * @param mcRequiredInstances MC Required Instances
+ * @param laPredicted LA Predicted
+ * @param laThreshold LA Threshold
+ * @param laRequiredInstance LA Required Instance
+ * @param requiredInstanceCount Required Instance Count
+ * @param activeInstanceCount Active Instance Count
+ * @param additionalInstanceCount Additional Instance Needed
+ * @param scalingReason Scaling Reason
+ */
+ public void publish(Long timestamp, String scalingDecisionId, String
clusterId,
+ int minInstanceCount, int maxInstanceCount,
+ int rifPredicted, int rifThreshold, int
rifRequiredInstances,
+ int mcPredicted, int mcThreshold, int
mcRequiredInstances,
+ int laPredicted, int laThreshold, int
laRequiredInstance,
+ int requiredInstanceCount, int
activeInstanceCount, int additionalInstanceCount,
+ String scalingReason);
--- End diff --
Arguments list is too long , if possible break into couple of method and
use method overloading or use a java pattern to overcome this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
