+1 The reason for generating the jndi.properties file was to allow cartridge agent to be configured using a single file. Yes it's better to follow the same pattern in all products.
On Wed, Apr 30, 2014 at 8:41 AM, Nirmal Fernando <[email protected]>wrote: > +1 Akila, Cartridge Agent also should follow the other products IMO. So, > let's add a jndi.properties file to agent and then configure it using > puppet. > > > > On Wed, Apr 30, 2014 at 8:10 AM, Akila Ravihansa Perera < > [email protected]> wrote: > >> Hi, >> >> Cartridge Agent currently uses a JndiConfigurator class to modify the >> jndi.properties file to set MB IP and MB port. It uses a >> jndi.properties.template file to generate this. But according to >> Stratos 4.0 architecture all the properties files should be generated >> from the Puppet scripts. >> >> IMO, this templating logic should be removed from the Cartridge >> Agent's end and should be done via Puppet scripts. If the community >> agrees to that I could work on a patch for this. WDYT? >> >> Thanks. >> >> -- >> Akila Ravihansa Perera >> Software Engineer >> WSO2 Inc. >> http://wso2.com >> >> Phone: +94 77 64 154 38 >> Blog: http://ravihansa3000.blogspot.com >> > > > > -- > Best Regards, > Nirmal > > Nirmal Fernando. > PPMC Member & Committer of Apache Stratos, > Senior Software Engineer, WSO2 Inc. > > Blog: http://nirmalfdo.blogspot.com/ > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PPMC Member, Apache Stratos
