Dear Cancai Cai,

Thank you for your dedication to reviewing PR progress and proposing the
waiting period idea. I greatly appreciate your efforts in striking a
balance between maintaining high standards and encouraging active community
participation. It is indeed crucial to find a harmonious balance that
facilitates productive collaboration while upholding the quality of
contributions.

I want to express my strong agreement with your proposal. Implementing a
structured waiting period seems like a thoughtful approach to ensure both
fairness and efficiency in the review process. This initiative could
positively impact the workflow and foster a more engaging and responsive
community environment.

Best regards,

Chao A (VampireAchao)

Cancai Cai <[email protected]> 于2024年1月14日周日 23:37写道:

> Dear a chao,
> I understand your concerns, and I think we can add a comment like this
> after approval: LGTM. If no one else has other opinions, I will merge this
> PR tomorrow. I believe this is acceptable to many developers
>
> Best wish,
> Cancai Cai
>
> chao a <[email protected]> 于2024年1月14日周日 23:25写道:
>
> > Dear Caican Cai,
> >
> > Thank you for reaching out and sharing your thoughts on the
> specifications
> > for future community merge PR. I appreciate your dedication to
> maintaining
> > the standards within the Streampark community.
> >
> > I understand your suggestion to introduce a measure of waiting for a day
> > before PMC or the submitter approves the PR and merges it. However, I
> have
> > a concern about whether this might reduce the enthusiasm of individuals
> > willing to submit PRs. I'm curious to know if other Apache communities
> > operate in a similar manner or if there are alternative approaches that
> > have been successful in maintaining standards while also encouraging
> active
> > participation.
> >
> > I believe that it's important to strike a balance between standardization
> > and maintaining an environment that fosters active contribution from
> > community members.
> >
> > Thank you for considering these points, and I look forward to further
> > discussion on this matter.
> >
> > Best regards,
> > Chao A (VampireAchao)
> >
> > caican cai <[email protected]> 于2024年1月14日周日 23:07写道:
> >
> > > Dear StreamPark:
> > > Hello everyone, regarding the title specification of streampark's pr.
> > Based
> > > on the last discussion, it can currently be controlled by the committer
> > and
> > > pmc, but it must be regulated according to the standards of the
> > community's
> > > official website. I think a measure can be added, which is to wait a
> day
> > > after a pmc or committer approves a PR before merging it, and see what
> > > else Does
> > > the committer or PMC have any other opinions? This is the approach of
> the
> > > Calcite community. I believe this can improve the standardization of
> the
> > > community. For example, I check the progress of each PR and the
> > > standardization of the PR title in the Streampark community every day.
> > >
> > > Best regards
> > > Cancai Cai
> > >
> > > link:
> > >
> > >
> >
> https://streampark.apache.org/community/submit_guide/code_style_and_quality_guide/
> > >
> >
>

Reply via email to