Cccccrystall commented on code in PR #1955: URL: https://github.com/apache/streampipes/pull/1955#discussion_r1367923564
########## installer/compose/quickstart/Dockerfile: ########## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# Use an official base image +FROM ubuntu:latest + +# Install curl and jq +RUN apt-get update \ + && apt-get install -y curl jq + + +RUN curl -L -o /usr/local/bin/wait-for-it.sh https://raw.githubusercontent.com/vishnubob/wait-for-it/81b1373f17855a4dc21156cfe1694c31d7d1792e/wait-for-it.sh \ Review Comment: Hi, @bossenti ! I have resolved all the commonts by doing the following changes: 1. Removing the logic of using wait-for-it.sh, and implementing the same logic in upload.sh to wait the backend service loading. 2. Enriching the example assets, making the asset and component to contain specific name and description, cleaning up empty dashboards and redundant elements, offering meaningful dashboards and data view for specific application scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
