bossenti commented on code in PR #1955: URL: https://github.com/apache/streampipes/pull/1955#discussion_r1368180950
########## installer/compose/quickstart/upload.sh: ########## @@ -0,0 +1,100 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#!/bin/bash +if [ -z "$SP_INITIAL_ADMIN_EMAIL" ]; then + USERNAME="[email protected]" +else + USERNAME="$SP_INITIAL_ADMIN_EMAIL" +fi + +if [ -z "$SP_INITIAL_ADMIN_PASSWORD" ]; then + PASSWORD="admin" +else + PASSWORD="$SP_INITIAL_ADMIN_PASSWORD" +fi + +while true; do + if curl -s "http://backend:8030/streampipes-backend/api/v2/auth/login"; --max-time 3 &> /dev/null; then + break Review Comment: Ah sorry, I put my comment at the wrong statement... My only concern was: If we only wait 9s (3 seconds with max-time 3) the backend might not yet be available in some cases. In this case we shouldn't continue with the script because this would probably lead to errors later (for sure if the backend doesn't get ready in time). So me asking for termination was only thinking about this special edge case where the backend does not get ready within the specified waiting period. But when we extend the waiting period to 30 seconds (3 seconds with max-time 10) this should not occur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
