GitHub user tenthe edited a discussion: Removal of Temporary Migration Step in 
nginx `Dockerfile`

Hi @obermeier,

if I saw it correctly, you added following part to the 
[Dockerfile](https://github.com/apache/streampipes/blob/dev/ui/Dockerfile) for 
the UI container, right? See #2473.

```dockerfile
# Store a copy to have a version if the other is hidden in the volume.  
# Required for migration from 0.93.0 to 0.95.0.  
# Could be removed after the release of 0.95.0.  
RUN mkdir -p /etc/opt/nginx/  
RUN chown -R nginx:nginx /etc/opt/nginx/  
COPY nginx_config/default.conf.template /etc/opt/nginx/default.conf.template  
RUN chown -R nginx:nginx /etc/opt/nginx/default.conf.template  
```  

Can this section now be safely removed? Does its removal impact existing 
installations? Is there anything we need to consider when removing it?

What is the current best practice if users want to use their own default nginx 
configuration?

Cheers, 
Philipp

GitHub link: https://github.com/apache/streampipes/discussions/3446

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]

Reply via email to