GitHub user obermeier added a comment to the discussion: Removal of Temporary Migration Step in nginx `Dockerfile`
Hi @tenethe, Thank you for bringing this up. Yes, this section can be safely removed since a default.conf.template should now exist in /etc/nginx/conf.d. I will provide a PR to clean it up. Regarding best practices for customizing the NGINX I think a good practice would be to have the possibility to mount a custom default.conf. But currently, there are (scripts)[https://github.com/apache/streampipes/blob/dev/ui/docker-entrypoint.sh] which are changing this configuration and will influence the default.conf 1) If the env var NGINX_SSL=true the configuration from /app/nginx-confs/ssl.conf is used 2) The host of the http server adapter is configured base on SP_HTTP_SERVER_ADAPTER_ENDPOINT E.g. - SP_HTTP_SERVER_ADAPTER_ENDPOINT=extensions-iiot-minimal:8090 - SP_HTTP_SERVER_ADAPTER_ENDPOINT=extensions-all-jvm:8090 - Three possible solutions just came to my mind: 1. Adding an environment variable which tells the scripts not to manipulate or replace the default.conf 2. The second solution would be to instruct users to mount a /app/nginx-confs/ssl.conf bzw. a custom /etc/nginx/conf.d/default.conf.template 3. Do not provide a default.conf in the OCI image. If it a default.conf is mounted, it would be used; otherwise, the current behavior from docker-entrypoint.sh would apply. I like this idea, but I’m concerned that many users might not be aware that if they change the HTTP server image (e.g., extensions-iiot-minimal, extensions-all-jvm), they would also need to update the NGINX configuration accordingly. What do you think of these ideas? Cheers, Stefan GitHub link: https://github.com/apache/streampipes/discussions/3446#discussioncomment-12022706 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
