Joe Germuska wrote: <snip />
Psychologically, I would not deprecate the good old execute(1,2,3,4) yet. Else Struts 1.3 will make all the millions of existing Struts apps look old (which is the same as "bad" in the era of Nip/Tuck). "If people want to code the old way, let them" (quote of my lead developer), esp. on something as established as Struts. Bad enough Shale makes people mistakenly think that good old Struts is being abandoned. Deprecating tested methods won't help much imo.
Well, although I'm not sure I agree, this is exactly the kind of discussion I wanted to see before I committed anything, and I think keeping the costs of upgrading psychologically low is worth keeping in mind.
Perhaps, then, we simply leave ol' Action to go out to pasture, and simply make it easier to indicate that you want to use a command by using the flexible interpretation of "type" i outlined above. We could write an "ActionCommand" class which simply passed "execute(Context)" to "execute(ActionContext)", for those who wanted it (like I kind of do for all of our existing commands), but since ActionContext extends Context, the only requirement would be that "type" refer to an instance of *either* Action*or* Command. We could leave in the catalog/command syntax for people who have reason to specify by name instead of by class name (particularly when they want to use a chain instead of a single command.)
We can create an interface for Action w/o deprecating Action itself. I don't have a problem keeping Action around (in fact, since we are sticking with the 1.x naming, we pretty much have to), but we should take this opportunity and remove its dependency in Struts core. Action would still be around for those that want to use it as their base class.
FWIW, I think Frank's idea of supporting POJO's as actions is the best. The JSF model of "action" is, IMO, the way to go:
1. It is a POJO that doesn't have to extend or implement anything
2. It can have properties for simple pages that don't need separate forms
3. It can be scoped so this silly "threadsafe" thing can go away, and scoping at a session level even opens up new interesting possibilities.
Don
Don
I feel pretty good about this.
Didn't get many reactions on the ActionForm side -- any concerns about changes to it?
Joe
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
