DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=34849>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34849 ------- Additional Comments From [EMAIL PROTECTED] 2005-05-28 07:13 ------- (In reply to comment #18) > > 1) Are you prepared to support this on the user list? > > 2) Are you willing to provide documentation for the validator user guide? > > 3) Are you willing to provide some examples in the struts-examples webapp? > All of these should not be a problem and I am willing to do a documentation and > in general support it. Great. The main two from my point of view are the documentation and web examples. That way when someone posts a stupid question on the user list we can just point them to those two things. > > 4) Are you willing to provide unit tests for this validator? > This one is also not a problem, but I will need more information what kind of > unit test do you expect? If it is just plain expression evaluation - I do not > think that they should be in struts package since they are already done in JEXL > package (http://tinyurl.com/b376t). A basic set would be: 1) A condition that passes validation 2) A condition that fails validation 3) An exception thrown by the Expression.evaluate() method 4) An expression result that is null 5) A non-boolean expression result Anything additional would be a bonus, such as testing the objects your storing in the JexlContext. Its partly about testing that this validator's code is good, but its also about making sure that any other changes made to Struts don't mess up this validator - including new versions of software Struts depends on or JDK versions. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
