DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35703>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35703 ------- Additional Comments From [EMAIL PROTECTED] 2006-01-27 10:51 ------- I actually did address Niall's concerns. On the contrary, current implementation of Tiles Plugin (until version 1.2.x of Struts) breaks the contract of the RequestProcessor - and this can be demonstrated pretty easily. The patch proposed is meant to fix that. Why does it break the contract of the RequestProcessor then would you ask ? Each application is able to implement its own RequestProcessor(s), as you know, to satisfy its own specific requirements (and I just happen to have one which implements its own doInclude() and doForward() methods to face some multi-portal requirements, hence this bug report :-(, otherwise I probably wouldn't even have noticed the issue). In the case of Struts without Tiles there's no problem at all, it all works fine. When it comes to Tiles (until version 1.2.x of Struts), i.e. integrating Tiles with Struts via Tiles Plugin, the application-specific TilesRequestProcessor implementation is actually bypassed. This is certainly fine when you have Tiles standalone but it is not when it comes to Struts+Tiles integration. As a matter of fact any application implementing its own TilesRequestProcessor subclass (with specific doForward() and doInclude() implementations) does not work any more with current Tiles Plugin (until version 1.2.x of Struts). That's why the fix has been made at 2 levels which you may note now cares not to impact Tiles standalone (TilesUtilImpl is left as is - Niall's was correct about my first patch being too radical) and which now impacts Tiles integration with Struts only : - TilesRequestProcessor now explicitly call parent's doInclude() (exactly in the same way that doForward() does) - TilesUtilStrutsImpl and TilesUtilStrutsModuleImpl now rely on TilesRequestProcessor doInclude() and doForward() N.B.: making the patch I actually noticed that the person who wrote TilesUtilStrutsModuleImpl in the first place actually realized this had to be done, just look at the class header comments and you'll find : "Methods doForward() and doInclude() use their counterparts in the current RequestProcessor (todo)" -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
