I am ok with "moving" it to under struts as a module, to make it part of the release, so we don't have to release it (and vote!) as a separate artifact.
On Mon, Dec 28, 2009 at 10:57 AM, Martin Cooper <mart...@apache.org> wrote: > On Mon, Dec 28, 2009 at 10:29 AM, Wes Wannemacher <w...@wantii.com> wrote: >> If no one objects, i can take a stab at taking care of this tonight... > > I guess I sort of object, unless I'm the only one without a full and > clear picture of the fate of this new code base that we own. I think > we need to make sure we're all on the same page before we start making > changes. > >> I haven't looked much at Martin's check-in, but we only need to port >> the xwork-core artifact... So, my plan would be to copy the source to >> the struts2 folder as a first-class sub-project (adding it to the >> modules section of the struts2 parent pom). Then, if that build works >> out, the next check-ins can be renaming / refactoring of classes, etc. >> But, if xwork-core is placed in the struts2 folder, alongside >> struts2-core, struts2-plugins, etc., then, if nothing else, it will >> make releasing easier. I'd imagine that refactoring class and package >> names will be a bit troublesome. Although the IDE can handle most of >> it for us, the trick isn't the easy stuff, the trick is finding the >> classes that are no longer necessary and/or duplicated between >> codebases. >> >> Thoughts? > > What I checked in is the entire XWork repo, since XWork is now our > responsibility. That is, we don't have a copy of XWork that we're > maintaining, we own XWork now. We have adopted it, lock, stock and > barrel. If people need enhancements to XWork, they will come to us > from now on. (What we do with such requests is something we should > discuss at some point in the near future.) > > I was envisaging that we would add XWork to the 'current' external in > such a way that it would look exactly the same as it does today when > someone checks it out as a peer of the 'struts2' folder. I take it > this is not what you have in mind? > > I have to say that 'copy' is not a word I like to see in reference to > source control. ;-) It implies a forking of the code base that we > would need to be very sure about. Is that actually what you mean? > > -- > Martin Cooper > > >> -Wes >> >> On Mon, Dec 28, 2009 at 1:16 PM, Musachy Barroso <musa...@gmail.com> wrote: >>> Are we going to rename the maven artifact names and package names for 2.2? >>> >>> musachy >>> >>> On Sun, Dec 27, 2009 at 12:39 PM, Martin Cooper <mart...@apache.org> wrote: >>>> On Sun, Dec 27, 2009 at 12:30 PM, Paul Benedict <pbened...@apache.org> >>>> wrote: >>>>> I recommend we immediately SVN tag or branch the initial check in so >>>>> it can be refactored appropriately. >>>> >>>> I'm not sure I see a need to do that, given that we can create a tag >>>> or branch from a specific revision at any time. However, if you feel >>>> the need, you're welcome to do that. >>>> >>>> -- >>>> Martin Cooper >>>> >>>> >>>>> Paul >>>>> >>>>> On Sun, Dec 27, 2009 at 1:18 PM, Lukasz Lenart >>>>> <lukasz.len...@googlemail.com> wrote: >>>>>> 2009/12/27 Martin Cooper <mart...@apache.org>: >>>>>>> As many of you have no doubt noticed already, I've checked in the >>>>>>> XWork code base, and added the Apache License 2.0 headers. The new >>>>>>> XWork tree is here: >>>>>> >>>>>> Hurra!!! Thanks a lot! >>>>>> >>>>>> >>>>>> Regards >>>>>> -- >>>>>> Lukasz >>>>>> http://www.lenart.org.pl/ >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>>>>> For additional commands, e-mail: dev-h...@struts.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>>>> For additional commands, e-mail: dev-h...@struts.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>>> For additional commands, e-mail: dev-h...@struts.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >>> For additional commands, e-mail: dev-h...@struts.apache.org >>> >>> >> >> >> >> -- >> Wes Wannemacher >> >> Head Engineer, WanTii, Inc. >> Need Training? Struts, Spring, Maven, Tomcat... >> Ask me for a quote! >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >> For additional commands, e-mail: dev-h...@struts.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
