Just reposting Wes's comments ;-)

---------- Forwarded message ----------
From: Wes Wannemacher <w...@wantii.com>
Date: 2010/5/28
Subject: Re: Struts 2 docs
To: lukasz.len...@gmail.com


On Fri, May 28, 2010 at 3:02 AM, Lukasz Lenart
<lukasz.len...@googlemail.com> wrote:
> Hi,
>
> Struts 2 spaces are all the time messed up, code snippets are missing
> and css styles are the same. Please take a look:
>
> https://cwiki.apache.org/S2WIKI/troubleshooting-guide-migrating-from-struts-20x-to-21x.html
> missed code snippets
>
> http://struts.apache.org/2.x/docs/home.html
> http://struts.apache.org/2.x/docs/resources/space.css
> layout is so ugly, I tried few time copy back site.css from previous
> version but it's was overwritten all the time
>
> Any hints?
>
> I'm not a PMC so I cannot make any tests and so. Thanks to Wes I've
> got templates used by Autoexport plugin and what I found is this:

I am a PMC, so I'll jump in and help Lukasz with anything he needs.

>
> 1) #editReport() - now idea what's this, it's just showing up on a
> page, can be removed


I've looked at this as well, but unfortunately, I've been so crunched
for time lately that I can't do a full investigation (the story of our
lives, right?). Anyhow, that #editReport() macro appears to be
something that was part of our template before the confluence upgrade.
I remember some traffic on here about macros needing to be re-worked a
bit now, but I don't know where to look to see what used to be in that
macro. Any help or pointers on this would get us much further.

>
> 2) <link type="text/css" rel="stylesheet" href="$stylesheet"> - I
> think it should end with />

This may be a simple fix, I'll check if I can update the struts template.

>
> 3) <link type="text/css" rel="stylesheet"
> href="http://cwiki.apache.org/confluence/download/resources/confluence.ext.code:code/shStyles.css";>
> - it can be removed as it's pointing to not accessible resource.
>

I'll see if I can take care of this as well.

> The main problem is with the site.css, any idea why is it wrong?
>
>

This one I'm not sure about, but maybe someone else on here might know more.


-Wes

--
Wes Wannemacher

Head Engineer, WanTii, Inc.
Need Training? Struts, Spring, Maven, Tomcat...
Ask me for a quote!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to