2017-06-29 10:06 GMT+02:00 Yasser Zamani <yasser.zam...@live.com>: > Please wait! Maybe we don't have to convert them because I could compile > and pass tests of Struts 2.3.33 under JDK8 and maven 3.5.0 so we can > keep it alive :) > > To do this, we should do just two things on Struts 2.3.33: > > 1) Adding tools.jar from JDK7 to classpath of the maven. > > 2) Correcting four wrong tests. There are four wrong tests that are > dependent to the order of java HashMap iteration which is not guaranteed > to be consistent between JDK releases! > > If you agree, I can present these as a PR on support-2-3 ?
I prefer to keep this consistent, running this job on JDK8 doesn't make sense as this can produce problems when I would like to release a new version using JDK6 - this gives us a safety net. To sum up - our builds should support the release process and be consistent with the target Java versions. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
