Thank you :) I'll keep it. On 7/3/2017 5:12 PM, Christoph Nenning wrote: >> >> @Christoph >> >> You can see my proposal at [1]. I keep it and convert it to a PR on dev >> list demand if was needed. >> >> I could not add tools.jar from JDK7 to classpath of the maven just by >> S2's project files and I think committers can do it in jenkins because >> they have access and I do not and can not see what happens there. >> >> Sincerely Yours, >> Yasser. >> >> [1] >> github.com/apache/struts/compare/ >> support-2-3...yasserzamani:support-2-3-jdk8?expand=1 >> > > > Good to have it as fallback :) > > > > Regards, > Christoph > > > > > >> On 6/29/2017 1:17 PM, Christoph Nenning wrote: >>>>> Please wait! Maybe we don't have to convert them because I could >>> compile >>>>> and pass tests of Struts 2.3.33 under JDK8 and maven 3.5.0 so we can >>>>> keep it alive :) >>>>> >>>>> To do this, we should do just two things on Struts 2.3.33: >>>>> >>>>> 1) Adding tools.jar from JDK7 to classpath of the maven. >>>>> >>>>> 2) Correcting four wrong tests. There are four wrong tests that are >>>>> dependent to the order of java HashMap iteration which is not >>> guaranteed >>>>> to be consistent between JDK releases! >>>>> >>>>> If you agree, I can present these as a PR on support-2-3 ? >>>> >>>> I prefer to keep this consistent, running this job on JDK8 doesn't >>>> make sense as this can produce problems when I would like to release > a >>>> new version using JDK6 - this gives us a safety net. >>>> >>>> To sum up - our builds should support the release process and be >>>> consistent with the target Java versions. >>>> >>>> >>> >>> I also prefer to run builds with thier target jdk. >>> >>> @yasser >>> I would like to see your PR for support-2-3 anyway >>> >>> >>> Regards, >>> Christoph >>> >>> This Email was scanned by Sophos Anti Virus >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org >> For additional commands, e-mail: dev-h...@struts.apache.org >> > > This Email was scanned by Sophos Anti Virus >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
