cdmikechen created SUBMARINE-1227:
-------------------------------------

             Summary: The conflict of some resource names will shut down the 
operator
                 Key: SUBMARINE-1227
                 URL: https://issues.apache.org/jira/browse/SUBMARINE-1227
             Project: Apache Submarine
          Issue Type: Bug
          Components: Cloud-native Deployment
            Reporter: cdmikechen
             Fix For: 0.7.0


Test Case:
If a *submarine-server* already exists in the same namespace, when we create a 
CR (example-submarine.yaml), the following error will appear and the operator 
will shut down.

{code}
I0320 14:47:55.171196    7601 controller_builder.go:98] Setting up event 
handlers
I0320 14:47:55.171467    7601 controller.go:140] Starting Submarine controller
I0320 14:47:55.171476    7601 controller.go:143] Waiting for informer caches to 
sync
W0320 14:47:55.244680    7601 warnings.go:70] extensions/v1beta1 Ingress is 
deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
I0320 14:47:55.271682    7601 controller.go:148] Starting workers
I0320 14:47:55.271768    7601 controller.go:154] Started workers
I0320 14:47:55.271955    7601 controller.go:237] syncHandler: 
submarine/example-submarine
I0320 14:47:55.272112    7601 submarine_server.go:112] [createSubmarineServer]
W0320 14:47:55.550934    7601 warnings.go:70] extensions/v1beta1 Ingress is 
deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
I0320 14:47:55.660610    7601 submarine_server.go:119]  Create ServiceAccount: 
I0320 14:47:55.660650    7601 submarine_database.go:78] 
[createSubmarineDatabase]
E0320 14:47:55.661330    7601 runtime.go:78] Observed a panic: "invalid memory 
address or nil pointer dereference" (runtime error: invalid memory address or 
nil pointer dereference)
goroutine 165 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x210c440, 0x2d9cf70)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:74
 +0x95
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:48
 +0x86
panic(0x210c440, 0x2d9cf70)
        /usr/local/Cellar/go/1.16.5/libexec/src/runtime/panic.go:965 +0x1b9
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).checkSubmarineDependentsReady(0xc00025e400,
 0xc0004bc600, 0x50, 0xc000beac60, 0x11)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:477
 +0x159
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).syncHandler(0xc00025e400,
 0xc0000462a0, 0x1b, 0xc00049e510, 0xc00049e510)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:276
 +0x4a5
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).processNextWorkItem.func1(0xc00025e400,
 0x20afb80, 0xc0001ac260, 0x0, 0x0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:191
 +0xed
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).processNextWorkItem(0xc00025e400,
 0x203000)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:201
 +0x53
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).runWorker(...)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:165
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc00038dca0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155
 +0x5f
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc00038dca0, 0x2473460, 
0xc00038aa80, 0x1, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156
 +0x9b
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc00038dca0, 0x3b9aca00, 0x0, 
0x1, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
 +0x98
k8s.io/apimachinery/pkg/util/wait.Until(0xc00038dca0, 0x3b9aca00, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:90
 +0x4d
created by 
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).Run
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:151
 +0x2e5
panic: runtime error: invalid memory address or nil pointer dereference 
[recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x460 pc=0x1f561f9]

goroutine 165 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:55
 +0x109
panic(0x210c440, 0x2d9cf70)
        /usr/local/Cellar/go/1.16.5/libexec/src/runtime/panic.go:965 +0x1b9
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).checkSubmarineDependentsReady(0xc00025e400,
 0xc0004bc600, 0x50, 0xc000beac60, 0x11)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:477
 +0x159
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).syncHandler(0xc00025e400,
 0xc0000462a0, 0x1b, 0xc00049e510, 0xc00049e510)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:276
 +0x4a5
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).processNextWorkItem.func1(0xc00025e400,
 0x20afb80, 0xc0001ac260, 0x0, 0x0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:191
 +0xed
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).processNextWorkItem(0xc00025e400,
 0x203000)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:201
 +0x53
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).runWorker(...)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:165
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc00038dca0)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155
 +0x5f
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc00038dca0, 0x2473460, 
0xc00038aa80, 0x1, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156
 +0x9b
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc00038dca0, 0x3b9aca00, 0x0, 
0x1, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
 +0x98
k8s.io/apimachinery/pkg/util/wait.Until(0xc00038dca0, 0x3b9aca00, 0xc000116d80)
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:90
 +0x4d
created by 
github.com/apache/submarine/submarine-cloud-v2/pkg/controller.(*Controller).Run
        
/Users/chenxiang/Documents/git/submarine/submarine-cloud-v2/pkg/controller/controller.go:151
 +0x2e5
{code}

The processing of resources with the same name should catch exceptions and 
update status instead of throwing them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to