Stefan Sperling <[email protected]> writes:

> What about the patch below?
>
> [[[
> * subversion/svnsync/main.c
>   (get_lock): The lock attempt is done in iteration N, and success is
>    checked in iteration N+1. Prevent the case where svnsync attempts
>    to take the lock in the very last iteration, doesn't check for
>    success, and ends up erroring out, leaving behind a stale lock.
>
> Found by: Jon Foster <[email protected]>
> Based on patch by: philip
> ]]]

Yes, that sort of thing.  Jon's patch was more complicated because he
was also trying to avoid the pointless final sleep before exiting with
a "couldn't get lock" error.  I don't think one extra second sleep
really matters.

-- 
Philip

Reply via email to