Hi, Stefan Sperling wrote: > OK, I will commit it.
Thankyou. > There is a much worse race condition, however. Yep, your mail arrived whilst I was testing this race condition in a debugger. I can confirm it's a real bug. But for me, the biggest problem with svnsync's locking right now is that if the network connection between the servers fails during a sync, then the lock is not released. > For now, users cannot assume that svnsync will handle concurrent > syncs, and need to take care of synchronising sync jobs themselves. I really want a way to turn off svnsync's current locking, so I can use file locking instead (svn_io_file_lock2() or similar). This keeps all the locking on a single machine, so I don't have to worry about network failures. Even if a process dies unexpectedly, the OS will automatically release file locks. It would also be useful if svnsync had file locking built in. Would it be reasonable to add a "--local-lock-file FILENAME" option to svnsync, which would turn off the current locking and use file locking instead? If so, I can work on a patch to do this. (As an alternative, if you don't like having the locking built in, how about a "--no-remote-lock" option?) Kind regards, Jon ********************************************************************** This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Cabot Communications Limited Verona House, Filwood Road, Bristol BS16 3RY, UK +44 (0) 1179584232 Co. Registered in England number 02817269 Please contact the sender if you believe you have received this email in error. ********************************************************************** ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
