Hyrum K. Wright wrote: >> Thanks for the reminder. Merging the changed suggested here (r876245) does >> indeed fix the test failure for me. > > Joe, > I'm happy to +0 this patch, since it fixes the failure for me. I've no idea > what it's doing under the hood, though, so I'd feel more comfortable if you > were able to +1 it.
Joe's changes are solid -- he's essentially just changed the Ruby wrapper around txdelta transmission to ignore the digest. (It passes NULL to the underlying C function so digest calculation never occurs.) And then he, of course, no longer returns the uncalculated digest to callers. My only concern here is that it's a change to the Ruby API over what's attempted in 1.6.x. If we're okay with that, you have my +1 to his fix. But if we're trying to maintain compat in our bindings layers, we'll need to do something different here. -- C. Michael Pilato <[email protected]> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
