If you have a moment, please add my +1. Thanks. Sent from my Windows Mobile® phone.
-----Original Message----- From: Hyrum K. Wright <[email protected]> Sent: Monday, April 12, 2010 4:51 AM To: Joe Swatosh <[email protected]> Cc: C. Michael Pilato <[email protected]>; Subversion Development <[email protected]> Subject: Re: 1.6.10 up for testing/signing On Sun, Apr 11, 2010 at 8:27 PM, Joe Swatosh <[email protected]> wrote: > Mike and Hyrum, > > On Mon, Apr 5, 2010 at 8:11 AM, C. Michael Pilato <[email protected]> > wrote: > > Hyrum K. Wright wrote: > >>> Thanks for the reminder. Merging the changed suggested here (r876245) > does > >>> indeed fix the test failure for me. > >> > >> Joe, > >> I'm happy to +0 this patch, since it fixes the failure for me. I've no > idea > >> what it's doing under the hood, though, so I'd feel more comfortable if > you > >> were able to +1 it. > > > > Joe's changes are solid -- he's essentially just changed the Ruby wrapper > > around txdelta transmission to ignore the digest. (It passes NULL to the > > underlying C function so digest calculation never occurs.) And then he, > of > > course, no longer returns the uncalculated digest to callers. > > > > My only concern here is that it's a change to the Ruby API over what's > > attempted in 1.6.x. If we're okay with that, you have my +1 to his fix
