Raphael Kubo da Costa wrote on Sun, Sep 02, 2012 at 07:02:59 -0300:
> Daniel Shahaf <d...@daniel.shahaf.name> writes:
>
> > Raphael Kubo da Costa wrote on Sat, Sep 01, 2012 at 11:05:02 -0300:
> >> What else needs to be done for it to be decided whether it makes sense
> >> to remove the check now?
> >
> > Send a patch that removes the check, ask people to test it on various
> > platforms, commit it if no one complains?
>
> Right, the patch below reverts r871309 by removing the NLS checks from
> kwallet.m4 -- it worked fine here with KDE from git master/svn trunk and
> gcc/libstdc++ 4.2.1 on FreeBSD. It'd be good to know if it works for
> other people as well.
>
For easier reviewing, here is the 'svn diff -x-w' version of the patch
you just sent:
% $svn di -x-w build/ac-macros/kwallet.m4
Index: build/ac-macros/kwallet.m4
===================================================================
--- build/ac-macros/kwallet.m4 (revision 1379958)
+++ build/ac-macros/kwallet.m4 (working copy)
@@ -35,7 +35,6 @@
AC_MSG_RESULT([yes])
if test "$svn_enable_shared" = "yes"; then
if test "$APR_HAS_DSO" = "yes"; then
- if test "$USE_NLS" = "yes"; then
if test -n "$PKG_CONFIG"; then
if test "$HAVE_DBUS" = "yes"; then
AC_MSG_CHECKING([for QtCore, QtDBus, QtGui])
@@ -101,9 +100,6 @@
AC_MSG_ERROR([cannot find pkg-config])
fi
else
- AC_MSG_ERROR([missing support for internationalization])
- fi
- else
AC_MSG_ERROR([APR does not have support for DSOs])
fi
else
