On Sun, Dec 16, 2012 at 10:43:26PM -0000, br...@apache.org wrote: > Author: brane > Date: Sun Dec 16 22:43:25 2012 > New Revision: 1422706 > > URL: http://svn.apache.org/viewvc?rev=1422706&view=rev > Log: > Print a warning in "svn --version" if plaintext password storage is enabled.
One more remark on this: > +#ifndef SVN_DISABLE_PLAINTEXT_PASSWORD_STORAGE > + { > + const char *warnstart = ""; > + const char *warnend = ""; > +#ifndef WIN32 > + if (isatty(fileno(stdout))) In the past we didn't use isatty() since there is no APR wrapper for it. If we're going to call isatty(), I think it would be best to implement a portable wrapper first that works on all platforms we support, so that it can also be used for other purposes. We could use iatty() to enable --non-interactive if output is not going to a terminal, for instance. This would prevent password or server cert prompts from hanging scripts where the auther of the script forgets to pass --non-interactive, which in my experience is a rather common problem. Apparently, Perl has an isatty() implementation that works on *nix and Windows that might serve as an example. Are you willing to look into that? That would be great!