Johan Corveleyn wrote on Wed, Oct 16, 2019 at 01:07:32 +0200: > I did have some trouble testing it with Python 3.7 though: > > - First, I had to try it on the swig-py3 branch, because on trunk I > get this when trying to run any test with py 3.7: ⋮ > I guess that's one of the issues fixed by the swig-py3 branch. > > - Then, on the swig-py3 branch, with py 3.7.4 I ran into this issue: > https://bugs.python.org/issue37549 (os.dup() fails for standard > streams on Windows 7) > This fails for any *.py test, because of line 836 in build/run_tests.py: ⋮ > > - Upgraded to py 3.7.5, in which the above issue seems to be fixed. > Now, *.py tests still don't work. I get no output at all: ⋮ > However, if I run it with --log-to-stdout, the tests do work (with a > lot of output on stdout). […]
Drive-by comment here, but: since Python 2 reaches EOL during the lifetime of the 1.13.x branch, I think it would be nice for us to make sure «make check» passes on Windows under Python 3… > Conclusion: I can confirm your patch works on Windows, for both Pyton > 2.7.16 and 3.7.5 on the swig-py3 branch. As for the stdout > redirection, I guess there might still be a problem ... perhaps the > fix for https://bugs.python.org/issue37549 is not sufficient for > Windows 7 ... dunno. Maybe someone can try this on Windows 10 and see > if it makes a difference. … although then again, Windows 7 reaches EOL rather soon too, so if the problem manifests only under Windows 7, it might well not be worth fixing. Cheers, Daniel
